Revise network definitions for HorizonOS #3863
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@ian-h-chamberlain @FenrirWolf @adryzz
Following some discussion in rust3ds/ctru-rs#174.
The changes include:
Update to the
hostent
definition for HorizonOS (armv6k-nintendo-3ds
) following upstream changes.A step back on the decision to remove the trailing zero bytes from
sockaddr_in
that was made all the way back in Horizon OS Nintendo 3DS - Fixed size of sockaddr_in #2725. This change will require a little work instd
, but we came to understand it's only right to keep the definitions true to the upstream versions.Also, should this PR be flagged for release in 0.2.x as well as the 1.0 milestone? Work on tier-3 targets isn't clearly talked about in the new contribution guidelines (not that this PR is of any relevance to the release process).